-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CA-144169: Removing unneeded XAPI calls for VBD.plug operation. #285
base: master
Are you sure you want to change the base?
Conversation
def09f9
to
3a97f89
Compare
@pritha-srivastava, how much is the performance improvement here? Most of the expensive calls The changes are undoubtedly an improvement and the patch is fine (apart from some style "violations") but we need to understand what is their impact. My educated guess is: negligible. |
@germanop - The VBD.plug call usually takes under 2 seconds to complete and these changes saved a few milliseconds. I am not sure what the impact would have been when I would have tested that for a 16 host bootstorm case (I couldn't because XenRT didnt allow me to) |
In function from_uuid:
There are others in the other functions |
3a97f89
to
66b0b5d
Compare
@germanop: I have updated the commit message. Let me know if there are other changes to be done. |
drivers/blktap2.py
Outdated
sm_config = self._session.xenapi.VDI.get_sm_config(vdi_ref) | ||
attached_as = util.attached_as(sm_config) | ||
if NO_MULTIPLE_ATTACH and (attached_as == "RW" or \ | ||
(attached_as == "RO" and attach_mode == "RW")): | ||
util.SMlog("need to reset VDI %s" % vdi_uuid) | ||
if not resetvdis.reset_vdi(self._session, vdi_uuid, force=False, | ||
term_output=False, writable=writable): | ||
term_output=False, writable=writable, vdiref=vdi_ref, | ||
srref=host_ref, smconf=sm_config): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe sr_ref?
66b0b5d
to
a883618
Compare
@germanop : All the review comments have been incorporated |
2c3ec8f
to
ae5f433
Compare
Signed-off-by: Pritha Srivastava <[email protected]>
ae5f433
to
4dda2ff
Compare
CA-144169: Fix to remove XAPI calls to improve time taken by VBD plug.
Signed-off-by: Pritha Srivastava [email protected]